Re: Formatting Curmudgeons WAS: MMAP Buffers

Andrew Dunstan <andrew@dunslane.net>

From: Andrew Dunstan <andrew@dunslane.net>
To: Jeff Janes <jeff.janes@gmail.com>
Cc: Christopher Browne <cbbrowne@gmail.com>, Greg Smith <greg@2ndquadrant.com>, PG Hackers <pgsql-hackers@postgresql.org>
Date: 2011-04-17T14:27:20Z
Lists: pgsql-hackers

Attachments


On 04/17/2011 09:51 AM, Andrew Dunstan wrote:
>
>
> On 04/17/2011 04:26 AM, Andrew Dunstan wrote:
>>
>>
>> Now we could certainly make this quite a bit slicker. Apart from 
>> anything else, we should change the indent source code tarball so it 
>> unpacks into its own directory. Having it unpack into the current 
>> directory is ugly and unfriendly. And we should get rid of the "make 
>> clean" line in the install target of entab's makefile, which just 
>> seems totally ill-conceived.
>>
>> It might also be worth setting it up so that instead of having to 
>> pass a path to a typedefs file on the command line, we default to a 
>> file sitting in, say, /usr/local/etc. Then you'd just be able to say 
>> "pgindent my_file.c".
>>
>>
>
> OK, I have most of these bits.
>
> A new tarball of indent is available at
> <http://developer.postgresql.org/~andrew/indent.netbsd.patched.tgz> 
> and if everyone agrees I'll push it out to the mirrors.
>
> Attached are two patches, one to remove some infelicity in the entab 
> makefile, and the other to allow skipping specifying the typedefs file 
> location either by setting it in an environment variable or by putting 
> it in a hard coded location.
>
>

... and this one has a typo fixed.

cheers

andrew