Re: wCTE behaviour

Marko Tiikkaja <marko.tiikkaja@cs.helsinki.fi>

From: Marko Tiikkaja <marko.tiikkaja@cs.helsinki.fi>

To: David Fetter <david@fetter.org>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter_e@gmx.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Robert Haas <robertmhaas@gmail.com>, Yeb Havinga <yebhavinga@gmail.com>, Hitoshi Harada <umi.tanuki@gmail.com>

Date: 2011-01-15T20:23:43Z

Lists: pgsql-hackers

Attachments

wcte.patch (text/plain) patch

On 2010-12-23 6:55 PM +0200, David Fetter wrote:
> Here's a document-included version :)

And here's the latest version of the patch for the last commit fest for 9.1.

I fixed an issue with the portal logic, and now we use 
PORTAL_ONE_RETURNING for wCTE queries, even if the main query is not a 
DML or does not have RETURNING.  This also means that we materialize the 
results of the main query sometimes unnecessarily, but that doesn't look 
like an easy thing to fix.  PORTAL_ONE_RETURNING as a name is also a bit 
misleading now, so maybe that needs changing..

Any feedback welcome.


Regards,
Marko Tiikkaja