Horton

Re: Streaming base backups

Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>

View thread
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Magnus Hagander <magnus@hagander.net>, Fujii Masao <masao.fujii@gmail.com>, Cédric Villemain <cedric.villemain.debian@gmail.com>, Dimitri Fontaine <dimitri@2ndquadrant.fr>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2011-01-15T15:35:34Z
Lists: pgsql-hackers 
On 15.01.2011 17:30, Tom Lane wrote:
> Heikki Linnakangas<heikki.linnakangas@enterprisedb.com>  writes:
>> BTW, I just spotted a small race condition between creating a new table
>> space and base backup. We take a snapshot of all the tablespaces in
>> pg_tblspc before calling pg_start_backup(). If someone creates a new
>> tablespace and puts some data in it in the window between base backup
>> acquiring the list tablespaces and starting the backup, the new
>> tablespace won't be included in the backup.
>
> So what?  The needed actions will be covered by WAL replay.

No, they won't, if pg_base_backup() is called *after* getting the list 
of tablespaces.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com