Re: some comments rewording in recovery.conf.sample about SR

Jehan-Guillaume (ioguix) de Rorthais <ioguix@free.fr>

From: "Jehan-Guillaume (ioguix) de Rorthais" <ioguix@free.fr>
To: pgsql-hackers@postgresql.org
Date: 2011-01-07T12:23:17Z
Lists: pgsql-hackers

Attachments

Obviously...

PFA

Le 07/01/2011 13:22, Jehan-Guillaume (ioguix) de Rorthais a écrit :
> Hello Hackers,
> 
> I believe comments in the recovery.conf.sample are somehow confusing
> about standby and SR:
> 
>   # Edit this file to provide the parameters that PostgreSQL needs to
>   # perform an archive recovery of a database, or to act as a log-streaming
>   # replication standby.
> 
> It seems incomplete. It doesn't recover OR act as a log-streaming
> replication standby. It can behave as a standby node without SR as well.
> 
>   # When standby_mode is enabled, the PostgreSQL server will work as
>   # a standby. It tries to connect to the primary according to the
>   # connection settings primary_conninfo, and receives XLOG records
>   # continuously.
> 
> This one is quite unclear as well. We might think that once we are in
> standby_mode we will be in SR. Again, we can use the standby_mode
> without primary_conninfo. This parameter only allows to keep the cluster
> in recovery, it doesn't imply to set up the SR.
> 
>   # By default, a standby server keeps streaming XLOG records from the
>   # primary indefinitely.
> 
> Same story...
> 
> Please, find in attachment a proposal of rewording.
> 
> Comments ?
> 
> Regards,