Horton

Re: pg_dump --split patch

Hannu Krosing <hannu@2ndquadrant.com>

View thread
From: Hannu Krosing <hannu@2ndquadrant.com>
To: pgsql-hackers@postgresql.org
Date: 2011-01-04T10:09:10Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pg_dump: Output functions deterministically sorted

  2. When sorting functions in pg_dump, break ties (same name) by number of arguments

On 28.12.2010 23:51, Tom Lane wrote:
> Andrew Dunstan<andrew@dunslane.net>  writes:
>> On 12/28/2010 04:44 PM, Joel Jacobson wrote:
>>> Perhaps abbreviations are to prefer, e.g., myfunc_i, myfunc_i_c, etc
>>> to reduce the need of truncating filenames.
>> I think that's just horrible. Does the i stand for integer or inet? And
>> it will get *really* ugly for type names with spaces in them ...
> You think spaces are bad, try slashes ;-)
>
> Not to mention the need for including schemas in typenames sometimes.
> I think you're going to have a real problem trying to fully describe a
> function's signature in a file name of reasonable max length.
something like

funcname_<number-of-arguments>_<hash_of_argument_type_list>.sql

seems like a reasonable compromise - you can find the function you are 
looking for without too much searching, even when overloaded and the 
uniqueness is still guaranteed.

--------------------------------------------
Hannu Krosing
http://www.2ndQuadrant.com/books/