Horton

Re: pg_dump --split patch

Hannu Krosing <hannu@2ndquadrant.com>

View thread
From: Hannu Krosing <hannu@2ndquadrant.com>
To: pgsql-hackers@postgresql.org
Date: 2011-01-04T10:06:04Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pg_dump: Output functions deterministically sorted

  2. When sorting functions in pg_dump, break ties (same name) by number of arguments

On 28.12.2010 22:44, Joel Jacobson wrote:
>
>
> Sent from my iPhone
>
> On 28 dec 2010, at 21:45, Gurjeet Singh <singh.gurjeet@gmail.com 
> <mailto:singh.gurjeet@gmail.com>> wrote:
>
>> The problem I see with suffixing a sequence id to the objects with 
>> name collision is that one day the dump may name myfunc(int) as 
>> myfunc.sql and after an overloaded version is created, say 
>> myfunc(char, int), then the same myfunc(int) may be dumped in 
>> myfunc-2.sql, which again is non-deterministic.
>
> I agree, good point!
> Perhaps abbreviations are to prefer, e.g., myfunc_i, myfunc_i_c, etc 
> to reduce the need of truncating filenames.
>
>
>>
>> Also, it is a project policy that we do not introduce new features in 
>> back branches, so spending time on an 8.4.6 patch may not be the best 
>> use of your time.
>
> My company is using 8.4 and needs this feature, so I'll have to patch 
> it anyway :)
Start the easy way, by writing a (python|perl) filter for pg_dump -s output

Once this is done, convert it into a patch for pg_dump

--------------------------------------------
Hannu Krosing
http://www.2ndQuadrant.com/books/