Horton

Re: and it's not a bunny rabbit, either

Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>

View thread
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Itagaki Takahiro <itagaki.takahiro@gmail.com>, pgsql-hackers@postgresql.org
Date: 2010-12-29T09:09:56Z
Lists: pgsql-hackers 
On 29.12.2010 06:54, Robert Haas wrote:
>   With the patch:
>
> rhaas=# cluster v;
> ERROR:  views do not support CLUSTER

"do not support" sounds like a missing feature, rather than a 
nonsensical command. How about something like "CLUSTER cannot be used on 
views"

The patch changes a bunch of heap_openrv() calls to relation_openrv(). 
Perhaps it would be better make the error message something like "\"%s\" 
is not a table", and keep the callers unchanged. It's not particularly 
useful to repeat the command in the error message, the user should know 
what command he issued. Even if it's buried deep in a PL/pgSQL function 
or something, it should be clear from the context lines.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com