Horton

Re: SQL/MED - core functionality

Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>

View thread
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Shigeru HANADA <hanada@metrosystems.co.jp>, pgsql-hackers@postgresql.org
Date: 2010-12-28T09:59:09Z
Lists: pgsql-hackers 
On 28.12.2010 05:16, Robert Haas wrote:
> I'd appreciate some review of what's attached, even though it's not
> totally final yet.

This construct doesn't translate well:

> +		appendStringInfo(&allowed, "table%s%s%s",
> +			allowView ? " or view" : "",
> +			allowType ? " or composite type" : "",
> +			allowForeignTable ? " or foreign table" : "");

Typo here:

> @@ -6883,7 +6962,7 @@ ATExecChangeOwner(Oid relationOid, Oid newOwnerId, bool recursing, LOCKMODE lock
>  		default:
>  			ereport(ERROR,
>  					(errcode(ERRCODE_WRONG_OBJECT_TYPE),
> -					 errmsg("\"%s\" is not a table, view, or sequence",
> +					 errmsg("\"%s\" is not a table, view, sequence, or foreign tabl, or foreign tablee",
>  							NameStr(tuple_class->relname))));
>  	}
>

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com