Re: MingW and MiniDumps
Andrew Dunstan <andrew@dunslane.net>
From: Andrew Dunstan <andrew@dunslane.net>
To: Magnus Hagander <magnus@hagander.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-12-26T00:10:56Z
Lists: pgsql-hackers
Attachments
- crashdump.patch (text/x-patch) patch
On 12/20/2010 01:25 PM, Magnus Hagander wrote: > On Mon, Dec 20, 2010 at 19:24, Tom Lane<tgl@sss.pgh.pa.us> wrote: >> Andrew Dunstan<andrew@dunslane.net> writes: >>> Maybe. I have no idea where narwhal got its version of dbghelp.h. I >>> copied the file from the SDK directory to mingw's include directory and >>> the build then ran perfectly. I think therefore the right thing is to >>> have a configure test for the file and for MINIDUMP_TYPE on win32, and >>> only build in crashdump if it passes those tests. > +1. > > Suggested patch attached. cheers andrew