Horton

Re: How much do the hint bits help?

Mark Kirkwood <mark.kirkwood@catalyst.net.nz>

View thread
From: Mark Kirkwood <mark.kirkwood@catalyst.net.nz>
To: Merlin Moncure <mmoncure@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-12-22T03:03:30Z
Lists: pgsql-hackers 
On 22/12/10 13:56, Merlin Moncure wrote:
> On Tue, Dec 21, 2010 at 7:45 PM, Tom Lane<tgl@sss.pgh.pa.us>  wrote:
>
> @Mark: apparently the cvs server is behind git and there are some
> recent changes to heapam.c that need more attention.  I need to get
> git going on my box, but try changing this:
>
> 	if ((tuple->t_infomask&  HEAP_XMIN_COMMITTED) ||
> 		(!(tuple->t_infomask&  HEAP_XMIN_COMMITTED)&&
> 		!(tuple->t_infomask&  HEAP_XMIN_INVALID)&&
> 		TransactionIdDidCommit(xmin)))
>
> to this:
>
> 	if (TransactionIdDidCommit(xmin))
>
> also, isn't the extra check vs HEAP_XMIN_COMMITTED redundant, and if
> you do have to look up clog, why not set the hint bit?
>

That gets it compiling.