Horton

Re: Complier warnings on mingw gcc 4.5.0

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Magnus Hagander <magnus@hagander.net>, Alvaro Herrera <alvherre@commandprompt.com>, Itagaki Takahiro <itagaki.takahiro@gmail.com>, Hiroshi Inoue <inoue@tpf.co.jp>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2010-12-16T16:40:27Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Make the win32 putenv() override update *all* present versions of the

  2. Remove the use of the pg_auth flat file for client authentication.


On 12/15/2010 11:53 PM, Tom Lane wrote:
>
> OK, patch committed so we can get testing from the existing buildfarm
> members, but please try on your new installation too.
>
> 			

It's working, but I don't think it's right :-) In particular, I don't 
believe this, or rather I don't believe that its converse is false:

    /* If not HAVE_GETOPT, we are using src/port/getopt.c, which has
    optreset */


The trouble is that while we've forced use of our getopt.c, we haven't 
inhibited configure from checking the system's getopt. So on my test 
system HAVE_GETOPT is defined. Possibly I was wrong about needing to 
have optreset set with use of our port.

cheers

andrew