Horton

Re: Remove unneeded cast in heap_xlog_lock.

Chao Li <li.evan.chao@gmail.com>

View thread View on postgr.es
From: Chao Li <li.evan.chao@gmail.com>
To: Kirill Reshke <reshkekirill@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-08-22T00:44:17Z
Lists: pgsql-hackers 

> On Aug 21, 2025, at 22:10, Kirill Reshke <reshkekirill@gmail.com> wrote:
> 
> Hi!
> 
> I was looking at how PostgreSQL handles VM map bits, when I noticed $subj.
> PFA small refactoring patch.
> 
> -- 
> Best regards,
> Kirill Reshke
> <v1-0001-Remove-unneeded-cast-in-heap_xlog_lock.patch>



LGTM. BufferGetPage() returns a “Page” type, and the receiving variable “page” is of “Page” type as well, so the cast is not needed.

--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

Commits

  1. Remove unneeded casts of BufferGetPage() result