Re: Additional options for Sync Replication
Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
To: Simon Riggs <simon@2ndQuadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2011-03-28T11:05:35Z
Lists: pgsql-hackers
On 28.03.2011 13:14, Simon Riggs wrote: > On Mon, Mar 28, 2011 at 10:52 AM, Simon Riggs<simon@2ndquadrant.com> wrote: >> >> You have no basis on which to prevent this. > > It's also already on the Open Items list, put there by you. > > Why is this even a discussion point? FWIW, I agree this is an additional feature that we shouldn't be messing with at this point in the release cycle. The 'apply' mode would be quite interesting, it would make it easier to build load-balancing clusters. But the patch isn't up to the task on that yet - the 'apply' status report is only sent after wal_receiver_status_interval fills up, so you get long delays. PS. you're missing some break's in the switch-statement in SyncRepWaitForLSN(), effectively making the patch do nothing. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com