Re: pgindent (was Re: Header comments in the recently added files)
Andrew Dunstan <andrew@dunslane.net>
From: Andrew Dunstan <andrew@dunslane.net>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Bruce Momjian <bruce@momjian.us>, Tom Lane <tgl@sss.pgh.pa.us>, Itagaki Takahiro <itagaki.takahiro@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2011-03-10T16:05:19Z
Lists: pgsql-hackers
On 03/10/2011 10:33 AM, Robert Haas wrote: > On Thu, Mar 10, 2011 at 10:21 AM, Bruce Momjian<bruce@momjian.us> wrote: >> Tom Lane wrote: >>> Itagaki Takahiro<itagaki.takahiro@gmail.com> writes: >>>> I found trivial mistakes in the recently added files. >>>> Will they fixed by some automated batches, or by manual? >>>> - "Copyright (c) xxx-*2010*, PostgreSQL Global Development Group" >>>> in pg_collation.h, pg_foreign_table.h, basebackup.h, syncrep.h, >>>> pg_backup_directory.c and auth_delay.c. >>>> - "IDENTIFICATION $PostgreSQL$" in pg_collation.h, syncrep.h, and syncrep.c >>>> Other files has their actual paths in the same place. >>> It might be worth Bruce making another run of his copyright-update >>> script to fix the former problems. As for the latter problems, >> I ran it just now and nothing was changed, so we are OK now. > Speaking of running scripts, I think we should run pgindent now. > Please wait a few days at least. I am just setting up a new server at this very moment (now that SL6 is released) and will get a new FBSD buildfarm member extracting typedefs running. cheers andrew