Re: Re: PD_ALL_VISIBLE flag was incorrectly set happend during repeatable vacuum

Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>

From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>

To: PostgreSQL-development <pgsql-hackers@postgresql.org>

Cc: Greg Stark <gsstark@mit.edu>, daveg <daveg@sonic.net>

Date: 2011-03-08T08:37:24Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix a violation of WAL coding rules in the recent patch to include an
- 7fc7a7c4d082 9.0.0 cited

Attachments

silence-bogus-all-visible-warning-1.patch (text/x-diff) patch

On 08.03.2011 10:00, Heikki Linnakangas wrote:
> Another idea is to give up on the warning when it appears that
> oldestxmin has moved backwards, and assume that it's actually fine. We
> could still warn in other cases where the flag appears to be incorrectly
> set, like if there is a deleted tuple on the page.

This is probably a better idea at least in back-branches. It also 
handles the case of twiddling vacuum_defer_cleanup_age, which tracking 
two xmins per transactions would not handle.

Here's a patch. I also changed the warning per Robert's suggestion. 
Anyone see a hole in this?

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com