Re: [HACKERS] Re: PD_ALL_VISIBLE flag was incorrectly set happend during repeatable vacuum

Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>

From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>

To: daveg <daveg@sonic.net>

Cc: Robert Haas <robertmhaas@gmail.com>, Greg Stark <gsstark@mit.edu>, David Christensen <david@endpoint.com>, Maxim Boguk <maxim.boguk@gmail.com>, Fujii Masao <masao.fujii@gmail.com>, pgsql-admin@postgresql.org, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2011-03-03T08:16:29Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix a violation of WAL coding rules in the recent patch to include an
- 7fc7a7c4d082 9.0.0 cited

Attachments

dont-trust-all-visible-flag.patch (text/x-diff) patch

On 03.03.2011 09:12, daveg wrote:
> Question: what would be the consequence of simply patching out the setting
> of this flag? Assuming that the incorrect PD_ALL_VISIBLE flag is the only
> problem (big assumption perhaps) then simply never setting it would at least
> avoid the possibility of returning wrong answers, presumably at some
> performance cost. We possibly could live with that until we get a handle
> on the real cause and fix.

Yes. With that assumption.

If you really want to do that, I would suggest the attached patch 
instead. This just disables the optimization in seqscans to trust it, so 
an incorrectly set flag won't affect correctness of query results,  but 
the flag is still set as usual and you still get the warnings so that we 
can continue to debug the issue.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com