Re: pg_basebackup and wal streaming

Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>

From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
To: Magnus Hagander <magnus@hagander.net>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2011-02-22T16:54:47Z
Lists: pgsql-hackers
On 18.02.2011 12:02, Magnus Hagander wrote:
> Better late than never (or?), here's the final cleanup of
> pg_streamrecv for moving into the main distribution, per discussion
> back in late dec or early jan. It also includes the "stream logs in
> parallel to backup" part that was not completed on pg_basebackup.

Looks reasonable at a quick glance.

> +		/* Already know when to stop, compare to the position we got */

That sentence sounds broken.

> + * The background stream will use it's own database connection so we can

s/it's/its/


-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com