Re: SQL/MED - file_fdw

Kevin Grittner <kevin.grittner@wicourts.gov>

From: "Kevin Grittner" <Kevin.Grittner@wicourts.gov>
To: "Noah Misch" <noah@leadboat.com>
Cc: "Itagaki Takahiro" <itagaki.takahiro@gmail.com>, "Robert Haas" <robertmhaas@gmail.com>, <hanada@metrosystems.co.jp>,<pgsql-hackers@postgresql.org>
Date: 2011-02-11T16:58:18Z
Lists: pgsql-hackers
Noah Misch <noah@leadboat.com> wrote:
 
> I'd say, run them with this patch alone.  The important thing is
> to not penalize existing COPY users.
 
Sounds good.
 
> Incidentally, the "did you want ... ?" was a genuine question.  I
> see very little performance risk here, so the tests could be quite
> cursory, even absent entirely.
 
>From what I've seen, I tend to agree.  If there's a committer ready
to go over this, I would say that it might be worth waiting for the
benchmark results against the patch from the day before yesterday to
be run before "pulling the trigger" on it; but proceed on the basis
that it's a near-certainty that it will test out OK.
 
-Kevin