Re: Named restore points
Euler Taveira de Oliveira <euler@timbira.com>
From: Euler Taveira de Oliveira <euler@timbira.com>
To: Simon Riggs <simon@2ndQuadrant.com>
Cc: Jaime Casanova <jaime@2ndquadrant.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2011-02-08T17:07:29Z
Lists: pgsql-hackers
Em 08-02-2011 11:05, Simon Riggs escreveu: > On Fri, 2011-02-04 at 21:15 -0500, Jaime Casanova wrote: >>> >>> + else if (recoveryTarget == RECOVERY_TARGET_NAME) >>> + snprintf(buffer, sizeof(buffer), >>> + "%s%u\t%s\t%s named restore point % >> s\n", >>> + (srcfd< 0) ? "" : "\n", >>> + parentTLI, >>> + xlogfname, >>> + recoveryStopAfter ? "after" : >> "before", >>> + recoveryStopNamedRestorePoint); >>> >>> It doesn't matter if it is after or before the restore point. >> After/Before >>> only make sense when we're dealing with transaction or time. >> Removed. >>> >> >> you're right > > Not sure I understand the comment "only make sense when we're dealing > with transaction or time." Why? > Because named restore point is a noop xlog record; besides, transaction and time involves xlog records that contain data. -- Euler Taveira de Oliveira http://www.timbira.com/