Re: Move WAL warning
Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
To: Magnus Hagander <magnus@hagander.net>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2011-02-02T16:43:59Z
Lists: pgsql-hackers
On 02.02.2011 16:36, Magnus Hagander wrote: > When running pg_basebackup with -x to include all transaction log, the > server will still throw a warning about xlog archiving if it's not > enabled - that is completely irrelevant since pg_basebackup has > included it already (and if it was gone, the base backup step itself > will fail - actual error and not warning). > > This patch moves the warning from do_pg_base_backup to pg_base_backup, > so it still shows when using the explicit function calls, but goes > away when using pg_basebackup. For the sake of consistency, how about moving the "pg_stop_backup complete, all required WAL segments have been archived" notice too? -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com