Re: REVIEW: Determining client_encoding from client locale
Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: Stephen Frost <sfrost@snowman.net>, Jaime Casanova <jaime@2ndquadrant.com>, Magnus Hagander <magnus@hagander.net>, pgsql-hackers@postgresql.org, Tom Lane <tgl@sss.pgh.pa.us>, Bruce Momjian <bruce@momjian.us>, Itagaki Takahiro <itagaki.takahiro@oss.ntt.co.jp>
Date: 2011-01-30T18:56:06Z
Lists: pgsql-hackers
On 29.01.2011 19:23, Peter Eisentraut wrote: >> > Also, do we really need a new set of states for this..? I would have >> > thought, just reading through the patch, that we could use the existing >> > OPTION_SEND/OPTION_WAIT states.. > Don't know. Maybe Heikki could comment; he wrote that initially. The other options send by the OPTION_SEND/WAIT machinery come from environment variables, there's a getenv() call where the SETENV_STATE_OPTION_SEND state is handled. It would be a bit awkward to shoehorn client_encoding into that. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com