Re: allow COPY routines to read arbitrary numbers of fields

On 12/06/2010 12:11 PM, Tom Lane wrote:
> Andrew Dunstan<andrew@dunslane.net>  writes:
>> Attached is a patch that allows CopyReadAttibutesText() and
>> CopyReadAttributesCSV() to read arbitrary numbers of attributes.
>> Underflowing attributes are recorded as null, and space is made for
>> overflowing attributes on a line.
> Why are you still passing nfields as a separate parameter instead of
> relying on the value you added to the struct?  That can't do anything
> except cause confusion, especially once the two values diverge due to a
> previous array-expansion.

Good point. will fix.

>    Also, why did you change the setup code to
> not compute nfields in binary mode?  That seems at best an unnecessary
> change, and at worst a breakage of the binary path --- did you test it?

AFAICT it's not used in binary mode at all. But I will double check.

> Also please be a little more careful with the formatting.

Ok, Will fix also. Thanks for he comments.

cheers

andre