Re: [PATCH] Revert default wal_sync_method to fdatasync on Linux 2.6.33+

Josh Berkus wrote:
> I modified test_fsync in two ways to run this; first, to make it support
> O_DIRECT, and second to make it run in the *current* directory.

Patch please?  I agree with the latter change; what test_fsync does is 
surprising.

I suggested a while ago that we refactor test_fsync to use a common set 
of source code as the database itself for detecting things related to 
wal_sync_method, perhaps just extract that whole set of DEFINE macro 
logic to somewhere else.  That happened at a bad time in the development 
cycle (right before a freeze) and nobody ever got back to the idea 
afterwards.  If this code is getting touched, and it's clear it is in 
some direction, I'd like to see things change so it's not possible for 
the two to diverge again afterwards.

-- 
Greg Smith   2ndQuadrant US    greg@2ndQuadrant.com   Baltimore, MD
PostgreSQL Training, Services and Support        www.2ndQuadrant.us