Horton

Re: pg_execute_from_file review

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>, Dimitri Fontaine <dimitri@2ndquadrant.fr>, Itagaki Takahiro <itagaki.takahiro@gmail.com>, Joshua Tolley <eggyknap@gmail.com>, pgsql-hackers@postgresql.org
Date: 2010-11-29T16:19:17Z
Lists: pgsql-hackers 

On 11/29/2010 11:12 AM, Tom Lane wrote:
> Andrew Dunstan<andrew@dunslane.net>  writes:
>> I'm not sure why you need either "from". It just seems like a noise
>> word. Maybe we could use pg_execute_query_file() and
>> pg_execute_query_string(), which would be fairly clear and nicely
>> symmetrical.
> +1, but I think "query" is also a noise word here.
> Why not just "pg_execute_file" and "pg_execute_string"?
>
> 			

Well, I put that in to make it clear that the file/string is expected to 
contain SQL and not, say, machine code. But I agree we could possibly do 
without it.

cheers

andrew