Horton

Re: pg_execute_from_file review

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Dimitri Fontaine <dimitri@2ndquadrant.fr>, Itagaki Takahiro <itagaki.takahiro@gmail.com>, Joshua Tolley <eggyknap@gmail.com>, pgsql-hackers@postgresql.org
Date: 2010-11-29T16:15:41Z
Lists: pgsql-hackers 

On 11/29/2010 10:51 AM, Robert Haas wrote:
>>
>> I'm not sure why you need either "from". It just seems like a noise word.
>> Maybe we could use pg_execute_query_file() and pg_execute_query_string(),
>> which would be fairly clear and nicely symmetrical.
> Because you execute queries, not files.  Or at least that's how I
> think about it.
>

Well, to me "pg_execute_query_file" says "execute the queries in this 
file". I'm not sure what else it could sensibly mean. But I think any of 
the suggestions will probably work OK.

cheers

andrew