Re: pg_execute_from_file review

Andrew Dunstan <andrew@dunslane.net>

From: Andrew Dunstan <andrew@dunslane.net>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Dimitri Fontaine <dimitri@2ndquadrant.fr>, Itagaki Takahiro <itagaki.takahiro@gmail.com>, Joshua Tolley <eggyknap@gmail.com>, pgsql-hackers@postgresql.org
Date: 2010-11-29T15:37:32Z
Lists: pgsql-hackers

On 11/29/2010 10:30 AM, Robert Haas wrote:
> On Mon, Nov 29, 2010 at 10:27 AM, Robert Haas<robertmhaas@gmail.com>  wrote:
>> On Mon, Nov 29, 2010 at 4:26 AM, Dimitri Fontaine
>> <dimitri@2ndquadrant.fr>  wrote:
>>>> * I'd like to ask native speakers whether "from" is needed in names
>>>>    of "pg_execute_from_file" and "pg_execute_from_query_string".
>>> Fair enough, will wait for some comments before producing a v6.
>> Yes, you need the from there.
> Eh, wait.  You definitely need from in pg_execute_from_file().  But
> pg_execute_from_query_string() doesn't sound quite right.  What does
> that function do, anyway?

I'm not sure why you need either "from". It just seems like a noise 
word. Maybe we could use pg_execute_query_file() and 
pg_execute_query_string(), which would be fairly clear and nicely 
symmetrical.

cheers

andrew