Horton

Re: why does plperl cache functions using just a bool for is_trigger

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alex Hunsaker <badalex@gmail.com>, Jan Urbański <wulczer@wulczer.org>, Postgres - Hackers <pgsql-hackers@postgresql.org>
Date: 2010-11-01T16:02:20Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove unnecessary use of trigger flag to hash plperl functions


On 11/01/2010 11:28 AM, Tom Lane wrote:
>   The fundamental issue here is that the contents of plperl_proc_desc
> structs are different between the trigger and non-trigger cases.
> Unless you're prepared to make them the same, and guarantee that they
> always will be the same in future, I think that including the istrigger
> flag in the hash key is a good safety feature.  It's also the same way
> that the other three PLs do things, and I see no good excuse for plperl
> to do things differently here.
>
> IOW, it's not broke, let's not fix it.

Ok, then let's make a note in the code to this effect. When the question 
was asked before about why it was there nobody seemed to have any good 
answer.

cheers

andrew