Horton

Re: why does plperl cache functions using just a bool for is_trigger

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jan Urbański <wulczer@wulczer.org>, Postgres - Hackers <pgsql-hackers@postgresql.org>
Date: 2010-10-31T18:00:41Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove unnecessary use of trigger flag to hash plperl functions


On 10/31/2010 11:44 AM, Tom Lane wrote:
> =?UTF-8?B?SmFuIFVyYmHFhHNraQ==?=<wulczer@wulczer.org>  writes:
>> Seems that this circumverts some output conversion error checking, since
>> adding the attached to the regression suite results in a segfault during
>> the plperl installcheck.
>> Reverting 2d01ec0708d571eef926f3f5795aa73759df5d9a fixes it.
> Good catch, patch reverted (and regression test added).

Well, I guess that answers the question of why we needed it, which 
nobody could answer before. I'm not sure I exactly understand what's 
going on here, though - I guess I need to look at it closer. At least I 
think we need a code comment on why the trigger flag is needed as part 
of the hash key.

cheers

andrew