Horton

Re: why does plperl cache functions using just a bool for is_trigger

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jan Urbański <wulczer@wulczer.org>, Postgres - Hackers <pgsql-hackers@postgresql.org>
Date: 2010-10-25T01:59:18Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove unnecessary use of trigger flag to hash plperl functions


On 10/24/2010 09:34 PM, Tom Lane wrote:
>
>> For both trigger and non-trigger functions, we compile this ahead of the
>> user-set function code:
>>      our $_TD; local $_TD=shift;
>> Non-trigger functions get passed "undef" to correspond to this invisible
>> argument, while trigger functions get passed the hashref that the
>> trigger calling code has set up.
> Seems like we don't need it then.  You going to get rid of it?

Ok, will do.

cheers

andrew