Re: Review: Fix snapshot taking inconsistencies

Marko Tiikkaja <marko.tiikkaja@cs.helsinki.fi>

View thread

From: Marko Tiikkaja <marko.tiikkaja@cs.helsinki.fi>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Steve Singer <ssinger_pg@sympatico.ca>, pgsql-hackers@postgresql.org, Alvaro Herrera <alvherre@commandprompt.com>

Date: 2010-10-21T12:32:54Z

Lists: pgsql-hackers

Attachments

snapshot4.patch (text/plain) patch

Hi,

Here's an updated patch.

I'm still not too fond of the logic in spi.c, but I can't see a better 
way to do this.  If someone sees a better way, I'm not going to object.

I also made some changes to the SQL functions now that we have a 
different API.  The previous code pushed and popped snapshots quite heavily.

I'd also like to see more regression tests for SQL functions, but I'm 
going to submit my suggestions as a separate patch.


Regards,
Marko Tiikkaja