Horton
Menu

Re: amcheck: Remove unused IndexCheckableCallback typedef

Andrey Borodin <x4mmm@yandex-team.ru>

View thread
From: Andrey Borodin <x4mmm@yandex-team.ru>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2025-07-04T08:25:26Z
Lists: pgsql-hackers 

> On 4 Jul 2025, at 10:50, Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
> 
> From the discussion in [1], it seems this typedef was originally used as
> a function argument in early versions of the patch. However,
> the argument was removed in v23, and the typedef was accidentally left behind.

Yes, your analysis is correct. We could make common checking function and argument was not needed.

> 
> The attached patch removes this unused typedef to clean up the dead code.
> Thoughts?

Looks good to me. Thanks for fixing this!


Best regards, Andrey Borodin.

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. amcheck: Remove unused IndexCheckableCallback typedef.

  2. amcheck: Move common routines into a separate module