Horton

Re: [PATCH] pgcrypto: Test for NULL before dereferencing pointer

Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>

View thread
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
To: Marti Raudsepp <marti@juffo.org>
Cc: pgsql-hackers@postgresql.org
Date: 2010-10-20T19:34:06Z
Lists: pgsql-hackers 
On 20.10.2010 18:44, Marti Raudsepp wrote:
> Hi pgsql-hackers,
>
> Currently contrib/pgcrypto/pgp-pubenc.c contains code like:
>
> uint8 algo = pk->algo;
> if (pk == NULL)
> ...
>
> However, if pk was NULL, then the if() condition would never be
> reached because the pk->algo dereference would segfault.
>
> This patch moves the dereference to below the condition which was the
> intended behavior.

Thanks, applied. Did coccicheck find anything else interesting?

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com