Re: WIP: extensible enums
Andrew Dunstan <andrew@dunslane.net>
From: Andrew Dunstan <andrew@dunslane.net>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Dean Rasheed <dean.a.rasheed@gmail.com>, pgsql-hackers@postgresql.org
Date: 2010-10-20T01:15:33Z
Lists: pgsql-hackers
On 10/19/2010 08:51 PM, Robert Haas wrote: > On Tue, Oct 19, 2010 at 5:42 PM, Andrew Dunstan<andrew@dunslane.net> wrote: >> Well a bit more testing shows some benefit. I've sorted out a few kinks, so >> this seems to work. In particular, with the above tables, the version >> imported from 9.0 can create have an index created in about the same time as >> on the fresh table (identical data, but all even numbered Oids). >> >> Of course, with lots of odd numbered Oids, if a label gets added the >> imported version will degrade in performance much more quickly. > I'm quite impressed by the amount of time and thought being put into > optimizing this. I didn't realize people cared so much about enum > performance; but it's good that they do. > > I hope to see more such efforts in other parts of the system. :-) Efficiency has always been one of the major reasons for using enums, so it's important that we make them extensible without badly affecting performance. cheers andrew