Re: WIP: extensible enums
Andrew Dunstan <andrew@dunslane.net>
From: Andrew Dunstan <andrew@dunslane.net>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Dean Rasheed <dean.a.rasheed@gmail.com>,
pgsql-hackers@postgresql.org
Date: 2010-10-13T11:33:58Z
Lists: pgsql-hackers
Attachments
- venum4.patch (text/x-patch) patch
On 10/13/2010 02:08 AM, Robert Haas wrote: > On Fri, Oct 1, 2010 at 7:12 AM, Andrew Dunstan<andrew@dunslane.net> wrote: >> On 10/01/2010 04:35 AM, Dean Rasheed wrote: >>> 2). In enum_ccmp(), when you cache the full list of elements, you're >>> not updating mycache->sort_list_length, so it will keep fetching the >>> full list each time. Also, I think that function could use a few more >>> comments. >> Good catch. Will fix. >> >>> 3). I think you need to update psql so that \dT+ returns the enum >>> elements in the right order. >> Yeah. Will do. >> >> I will post a revised patch soon. > Should we postpone this to the next CommitFest? Sorry, got distracted. Here's a new patch that fixes the above and also contains some documentation. cheers andrew