Horton

Re: encode/decode support for base64url

Daniel Gustafsson <daniel@yesql.se>

View thread
From: Daniel Gustafsson <daniel@yesql.se>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Florents Tselai <florents.tselai@gmail.com>, "David E. Wheeler" <david@justatheory.com>, Aleksander Alekseev <aleksander@tigerdata.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Cary Huang <cary.huang@highgo.ca>, Przemysław Sztoch <przemyslaw@sztoch.pl>
Date: 2025-09-18T19:19:07Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add support for base64url encoding and decoding

Attachments

> On 17 Sep 2025, at 19:51, Masahiko Sawada <sawada.mshk@gmail.com> wrote:

> Thank you for updating the patch! I've done additional tests in my
> environment and all test cases passed. One very minor comment is that
> we might want to add 'BASE64URL' to:
> 
> /*
> * BASE64
> */

I did that, and polished a few comments which had various version of case on
"base64url".  The RFC only mentions it in all lowercase so I went with that
apart from the in the comment mentioned above.

The attached v9 has this and

> Overall, the patch looks good to me. I'll wait for Daniel as he has
> polished this patch and might have some comments or want to take it.

Agreed, I think this is ready to go in.  If you want to push it then feel free,
else I'll take care of it tomorrow.

--
Daniel Gustafsson