Re: patch (for 9.1) string functions

Kevin Grittner <kevin.grittner@wicourts.gov>

From: "Kevin Grittner" <Kevin.Grittner@wicourts.gov>
To: "Itagaki Takahiro" <itagaki.takahiro@gmail.com>, "Pavel Stehule" <pavel.stehule@gmail.com>
Cc: "Merlin Moncure" <mmoncure@gmail.com>, "Takahiro Itagaki" <itagaki.takahiro@oss.ntt.co.jp>, "PostgreSQL Hackers" <pgsql-hackers@postgresql.org>
Date: 2010-07-12T17:17:25Z
Lists: pgsql-hackers
Itagaki Takahiro <itagaki.takahiro@gmail.com> wrote:
 
> I'd like to move all proposed functions into the core, and not to
> add contrib/stringfunc.
 
> Still failed :-(  I used UTF8 database with *locale=C* on 64bit
> Linux.
> char2wchar() doesn't seem to work on C locale. We should avoid
> using the function and converting mb chars to wide chars.
> 
>   select sprintf('>>>%10s %10d<<<', 'hello', 10);
> ! server closed the connection unexpectedly
> TRAP: FailedAssertion("!(!lc_ctype_is_c())", File: "mbutils.c",
> Line: 715)
> 
> #0  0x00000038c0c332f5 in raise () from /lib64/libc.so.6
> #1  0x00000038c0c34b20 in abort () from /lib64/libc.so.6
> #2  0x00000000006e951d in ExceptionalCondition
> (conditionName=<value optimized out>, errorType=<value optimized
> out>, fileName=<value optimized out>, lineNumber=<value optimized
> out>) at assert.c:57
> #3  0x00000000006fa8bf in char2wchar (to=0x1daf188 L"", tolen=16,
> from=0x1da95b0 "%*s", fromlen=3) at mbutils.c:715
> #4  0x00007f8e8c436d37 in stringfunc_sprintf
> (fcinfo=0x7fff9bdcd4b0)
> at stringfunc.c:463
 
Based on this and subsequent posts, I've changed this patch's status
to "Waiting on Author".
 
-Kevin