Re: [PATCH] Re: Adding XMLEXISTS to the grammar
Mike Fowler <mike@mlfowler.com>
From: Mike Fowler <mike@mlfowler.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2010-06-29T11:22:06Z
Lists: pgsql-hackers
Attachments
- xmlexists-5.patch (text/x-diff) patch
Mike Fowler wrote: > Thanks again for your help Robert, turns out the fault was in the > pg_proc entry (the 3 up there should've been a two!). Once I took the > grammar out it was quickly obvious where I'd gone wrong. > > Attached is a patch with the revised XMLEXISTS function, complete with > grammar support and regression tests. The implemented grammar is: > > XMLEXISTS ( xpath_expression PASSING BY REF xml_value [BY REF] ) > > Though the full grammar makes everything after the xpath_expression > optional, I've left it has mandatory simply to avoid lots of rework of > the function (would need new null checks, memory handling would need > reworking). > As with the xpath_exists patch I've now added the SGML documentation detailing this function and extended the regression test a little to test XML literals. Regards, -- Mike Fowler Registered Linux user: 379787