Horton
Menu

Re: refactoring comment.c

Kevin Grittner <kevin.grittner@wicourts.gov>

View thread
From: "Kevin Grittner" <Kevin.Grittner@wicourts.gov>
To: "Robert Haas" <robertmhaas@gmail.com>, "Peter Eisentraut" <peter_e@gmx.net>
Cc: "pgsql-hackers" <pgsql-hackers@postgresql.org>
Date: 2010-08-27T21:35:13Z
Lists: pgsql-hackers 
Robert Haas <robertmhaas@gmail.com> wrote:
 
> I suppose this is unhappy because it things elog(ERROR) might
> return?
 
It looks more like this code uses it without initialization:
 
        case OBJECT_INDEX:
        case OBJECT_SEQUENCE:
        case OBJECT_TABLE:
        case OBJECT_VIEW:
            relation =
                get_relation_by_qualified_name(objtype, objname,
lockmode);
            address.classId = RelationRelationId;
            address.objectId = RelationGetRelid(relation);
            address.objectSubId = 0;
            break;
 
-Kevin