Horton
Menu

Re: MERGE command for inheritance

Greg Smith <greg@2ndquadrant.com>

View thread
From: Greg Smith <greg@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Simon Riggs <simon@2ndQuadrant.com>, Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, Boxuan Zhai <bxzhai2010@gmail.com>, pgsql-hackers@postgresql.org
Date: 2010-08-11T16:49:05Z
Lists: pgsql-hackers

Attachments

Tom Lane wrote:
> Do we really think this is anywhere near committable now?
>   

There's a relatively objective standard for the first thing needed for 
commit--does it work?--in the form of the regression tests Simon put 
together before development.  I just tried the latest merge_v102.patch 
(regression diff attached) to see how that's going.  There are still a 
couple of errors in there.  It looks to me like the error handling and 
related DO NOTHING support are the next pair of things that patch needs 
work on.  I'd rather see that sorted out than to march onward to 
inheritance without the fundamentals even nailed down yet.

-- 
Greg Smith  2ndQuadrant US  Baltimore, MD
PostgreSQL Training, Services and Support
greg@2ndQuadrant.com   www.2ndQuadrant.us