Re: review: psql: edit function, show function commands patch
Jan Urbański <wulczer@wulczer.org>
From: Jan Urbański <wulczer@wulczer.org>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Postgres - Hackers <pgsql-hackers@postgresql.org>
Date: 2010-07-25T15:36:16Z
Lists: pgsql-hackers
On 23/07/10 20:55, Pavel Stehule wrote: > Hello > > 2010/7/23 Jan Urbański <wulczer@wulczer.org>: >> On 21/07/10 14:43, Pavel Stehule wrote: >>> Hello >>> >>> I am sending a actualised patch. OK, thanks. This time the only thing I'm not happy about is the error message from doing: \ef func 0 \e /etc/passwd xxx which gives: line number is unacceptable where I think it should do: \ef: line number is unacceptable \e: line number is unacceptable but that's too trivial to go through another round of review and I think the committer can fix this easily. The documentation likely needs some spelling fixes, but I'll leave that to a native English speaker. I'm setting this as ready for committer. Thanks, Jan