Re: [PATCH] Re: Adding XMLEXISTS to the grammar

On 21/07/10 08:33, Mike Fowler wrote:

>> Why is the first argument AexprConst instead of a_expr? The SQL
>> standard says it's a character string literal, but I think we can very
>> well allow arbitrary expressions.
>
> Yes, it was AexprConst because of the specification. I also found that
> using it solved my shift/reduce problems, but I can change it a_expr as
> see if I can work them out in a different way.

[snip]

>> Why c_expr?
>
> As with the AexprConst, it's choice was partially influenced by the fact
> it solved the shift/reduce errors I was getting. I'm guessing than that
> I should really use a_expr and resolve the shift/reduce problem
> differently?
>

Attached is the revised version of the patch addressing all the issues 
raised in the review, except for the use of AexprConst and c_expr. With 
my limited knowledge of bison I've failed to resolve the shift/reduce 
errors that are introduced by using a_expr. I'm open to suggestions as 
my desk is getting annoyed with me beating it in frustration!

Thanks again for taking the time to review my work.

Regards,

-- 
Mike Fowler
Registered Linux user: 379787