Re: log files and permissions

Tom Lane wrote:
> Itagaki Takahiro <itagaki.takahiro@gmail.com> writes:
>> ...
>> We should also check the value not to be something like 0699.
>> How about checking it with (file_mode & ~0666) != 0 ?
>> ...
>> I want show_log_file_mode to print the setting value in octal format.
> 
> It seems like a whole lot of lily-gilding is going on here.  Just make
> it work like unix_socket_permissions already does.  That's been there
> for years and nobody has complained about it.
> 

Thanks, somehow I missed that we can already specify octal integers
as GUC-s. I now converted the log_file_mode to integer and dropped
the assign_log_file_mode function.

regards,
Martin