Re: Remaining Streaming Replication Open Items

Robert Haas wrote:
> On Tue, Apr 13, 2010 at 11:49 AM, Heikki Linnakangas
> <heikki.linnakangas@enterprisedb.com> wrote:
>> We have the emode_for_corrupt_record() function that's used in all the
>> errors that indicate a corrupt WAL record, that's a perfect place to
>> hook this into. See attached patch.
> 
> The test for elog == LOG seems a bit fragile to me - why that
> specifically?  Maybe elog < PANIC?  elog > DEBUG1?  Both?

Suppressing anything >= ERROR wouldn't make sense, as ERRORs cause the
replay to abort. I didn't want to affect WARNINGs either, which indicate
that something is truly wrong. The only level left between DEBUG1, which
is what the message is downgraded to, and WARNING, is LOG.

-- 
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com