Horton
Menu

Thread

  1. Quoting in recovery.conf

    Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> — 2010-04-06T06:47:10Z

    To follow up on the discussion here:

http://archives.postgresql.org/pgsql-docs/2010-02/msg00039.php

It seems like a big oversight that there's no way to insert quotes in
strings in recovery.conf. In the long run, the parsing should be done
the same way as postgresql.conf, or the two files be merged altogether,
but right now I think we should just add support for escaping quotes. I
propose two quotes '' to mean a quote mark in the string, like in
strings in SQL queries.

-- 
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com

  2. Re: Quoting in recovery.conf

    Fujii Masao <masao.fujii@gmail.com> — 2010-04-06T07:07:37Z

    On Tue, Apr 6, 2010 at 3:47 PM, Heikki Linnakangas
<heikki.linnakangas@enterprisedb.com> wrote:
> To follow up on the discussion here:
>
> http://archives.postgresql.org/pgsql-docs/2010-02/msg00039.php
>
> It seems like a big oversight that there's no way to insert quotes in
> strings in recovery.conf. In the long run, the parsing should be done
> the same way as postgresql.conf, or the two files be merged altogether,
> but right now I think we should just add support for escaping quotes. I
> propose two quotes '' to mean a quote mark in the string, like in
> strings in SQL queries.

Agreed. This would be useful for users to specify the application_name
containing a space in the primary_conninfo, for example.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

  3. Re: Quoting in recovery.conf

    Simon Riggs <simon@2ndquadrant.com> — 2010-04-06T11:45:29Z

    On Tue, 2010-04-06 at 16:07 +0900, Fujii Masao wrote:
> On Tue, Apr 6, 2010 at 3:47 PM, Heikki Linnakangas
> <heikki.linnakangas@enterprisedb.com> wrote:
> > To follow up on the discussion here:
> >
> > http://archives.postgresql.org/pgsql-docs/2010-02/msg00039.php
> >
> > It seems like a big oversight that there's no way to insert quotes in
> > strings in recovery.conf. In the long run, the parsing should be done
> > the same way as postgresql.conf, or the two files be merged altogether,
> > but right now I think we should just add support for escaping quotes. I
> > propose two quotes '' to mean a quote mark in the string, like in
> > strings in SQL queries.
> 
> Agreed. This would be useful for users to specify the application_name
> containing a space in the primary_conninfo, for example.

+1

-- 
 Simon Riggs           www.2ndQuadrant.com

  4. Re: Quoting in recovery.conf

    Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> — 2010-04-06T16:48:11Z

    Simon Riggs wrote:
> On Tue, 2010-04-06 at 16:07 +0900, Fujii Masao wrote:
>> On Tue, Apr 6, 2010 at 3:47 PM, Heikki Linnakangas
>> <heikki.linnakangas@enterprisedb.com> wrote:
>>> To follow up on the discussion here:
>>>
>>> http://archives.postgresql.org/pgsql-docs/2010-02/msg00039.php
>>>
>>> It seems like a big oversight that there's no way to insert quotes in
>>> strings in recovery.conf. In the long run, the parsing should be done
>>> the same way as postgresql.conf, or the two files be merged altogether,
>>> but right now I think we should just add support for escaping quotes. I
>>> propose two quotes '' to mean a quote mark in the string, like in
>>> strings in SQL queries.
>> Agreed. This would be useful for users to specify the application_name
>> containing a space in the primary_conninfo, for example.
> 
> +1

Ok, here's what I came up with.

-- 
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com

  5. Re: Quoting in recovery.conf

    Fujii Masao <masao.fujii@gmail.com> — 2010-04-07T02:38:41Z

    On Wed, Apr 7, 2010 at 1:48 AM, Heikki Linnakangas
<heikki.linnakangas@enterprisedb.com> wrote:
> Ok, here's what I came up with.

Looks OK to me.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

  6. Re: Quoting in recovery.conf

    Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> — 2010-04-07T10:59:42Z

    Fujii Masao wrote:
> On Wed, Apr 7, 2010 at 1:48 AM, Heikki Linnakangas
> <heikki.linnakangas@enterprisedb.com> wrote:
>> Ok, here's what I came up with.
> 
> Looks OK to me.

Committed.

-- 
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com