Horton
Menu

Re: exec_execute_message crash

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Tatsuo Ishii <ishii@postgresql.org>
Cc: pgsql-hackers@postgresql.org
Date: 2009-12-30T12:59:25Z
Lists: pgsql-hackers 

Tatsuo Ishii wrote:
> ! 	if (!PortalIsValid(portal) || (PortalIsValid(portal) && portal->cleanup == NULL))
>  
>   


Surely the second call to PortalIsValid() is redundant.
      
    if (( !PortalIsValid(portal)) || portal->cleanup == NULL)

should do it, no?

cheers

andrew