Re: [PATCH] Provide rowcount for utility SELECTs
Boszormenyi Zoltan <zb@cybertec.at>
From: Boszormenyi Zoltan <zb@cybertec.at>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter_e@gmx.net>, Hans-Juergen Schoenig <hs@cybertec.at>, Pavel Stehule <pavel.stehule@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2009-12-28T18:29:01Z
Lists: pgsql-hackers
Tom Lane írta: > Peter Eisentraut <peter_e@gmx.net> writes: > >> On mĂĽn, 2009-12-28 at 11:08 -0500, Tom Lane wrote: >> >>> And, by the same token, the scope for possibly breaking clients is nearly >>> unlimited ... >>> > > >> Why is that? Are there programs out there that expect PQcmdTuples() to >> return something that is *not* the tuple count for these commands and >> will violently misbehave otherwise? >> > > It's more the possibility of doing strcmp(tag, "SELECT") on the command > Actually it's strncmp(tag, "SELECT ", 7), so when you mix old server with new clients or new server with old client, it will just work as before, i.e. return "". > tag that worries me. Describing the API change here as being limited > to PQcmdTuples misses the point rather completely: this is a protocol > change, and could break both clients and non-libpq driver libraries. > > regards, tom lane > > -- Bible has answers for everything. Proof: "But let your communication be, Yea, yea; Nay, nay: for whatsoever is more than these cometh of evil." (Matthew 5:37) - basics of digital technology. "May your kingdom come" - superficial description of plate tectonics ---------------------------------- Zoltán Böszörményi Cybertec Schönig & Schönig GmbH http://www.postgresql.at/