Re: [patch] executor and slru dtrace probes

Zdenek Kotala wrote:
> Bernd Helmle píše v po 14. 12. 2009 v 20:42 +0100:
>   
>> Oh, and i was under the opinion the last discussions were about executor 
>> probes only (note the patch is split up into two parts now, SLRU and 
>> executor probes). The latter won't be fixed, but it seems the SLRU part at 
>> least is ready.
>>     
>
> I would like to add  SimpleLruInit probe. I'm busy with PG packaging,
> but I hope that I will send updated version tomorrow.
>   
I'd like to see as many of these DTrace probes as possible make it into 
8.5, and it's great that you've picked up these older ones and updated 
them.  It looks like a lot of progress was made on actually measuring 
the overhead of adding these probes in even when they're not enabled, 
which is good.

But I'm afraid we're already out of time for this one if you're still 
tweaking the probes here.  With a functional change like that, our 
normal process at this point would be to have the reviewer re-evaluate 
things before they head to a committer, and I don't feel like this patch 
is quite at 100% yet--in particular, the probe documentation is 
improving but still a bit rough.  I don't feel like we're quite ready to 
mark this one for commit for this one, and today we really want to clear 
the queue for things for committers to deal with.  Please send that 
updated version, and let's keep working on this into the next 
CommitFest, where it will be in the front of the queue rather than how 
it ended up at the tail of this one just based on its submission date.  
You're not really getting a fair chunk of time here between your review 
and the end here because of problems lining up reviewer time, that 
shouldn't happen next time.

-- 
Greg Smith    2ndQuadrant   Baltimore, MD
PostgreSQL Training, Services and Support
greg@2ndQuadrant.com  www.2ndQuadrant.com