Horton

Re: EXPLAIN BUFFERS

Euler Taveira <euler@timbira.com>

View thread View on postgr.es
From: Euler Taveira de Oliveira <euler@timbira.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>, Greg Smith <greg@2ndquadrant.com>, Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@commandprompt.com>, Jeff Janes <jeff.janes@gmail.com>, Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2009-12-11T16:36:27Z
Lists: pgsql-hackers 
Robert Haas escreveu:
> On Thu, Dec 10, 2009 at 9:35 PM, Takahiro Itagaki
> <itagaki.takahiro@oss.ntt.co.jp> wrote:
>> Anyway, a revised patch according to the comments is attached.
>> The new text format is:
>>  Buffers: shared hit=675 read=968, temp read=1443 written=1443
>>    * Zero values are omitted. (Non-text formats could have zero values.)
>>    * Rename "Blocks:" to "Buffers:".
>>    * Remove parentheses and add a comma between shared, local and temp.
> 
> I did a bit of copy-editing of your doc changes to make the English a
> bit more correct and idiomatic.  Slightly revised patch attached for
> your consideration.  The output format looks really nice (thanks for
> bearing with me), and the functionality is great.
> 
Please, document that zero values are omitted in the text format. It seems
intuitive but could be surprise because zero values are in non-text formats.


-- 
  Euler Taveira de Oliveira
  http://www.timbira.com/