Horton

Re: tsearch parser inefficiency if text includes urls or emails - new version

Kevin Grittner <kevin.grittner@wicourts.gov>

View thread View on postgr.es
From: "Kevin Grittner" <Kevin.Grittner@wicourts.gov>
To: "Andres Freund" <andres@anarazel.de>, <pgsql-hackers@postgresql.org>, "Kevin Grittner" <Kevin.Grittner@wicourts.gov>
Cc: <greg@2ndquadrant.com>,<oleg@sai.msu.su>, <teodor@sigaev.ru>
Date: 2009-12-10T19:05:13Z
Lists: pgsql-hackers 
I wrote:
 
> I did find one significant (although easily solved) problem.  In
> the patch, the recursive setup of usewide, pgwstr, and wstr are
> not conditioned by #ifdef USE_WIDE_UPPER_LOWER in the non-patched
> version.  Unless there's a good reason for that, the #ifdef should
> be added.
 
That should read:
 
I did find one significant (although easily solved) problem.  In
the patch, the recursive setup of usewide, pgwstr, and wstr are
not conditioned by #ifdef USE_WIDE_UPPER_LOWER as they are in the
non-patched version.  Unless there's a good reason for that, the
#ifdef should be added.
 
-Kevin