Thread

1. compile error with -DOPTIMIZER_DEBUG

   Jan Urbański <wulczer@wulczer.org> — 2009-11-22T12:04:12Z

   Hi,
   
   ISTM that there's a superfluous curly brace in print_path (which only
   gets compiled with -DOPTIMIZER_DEBUG.
   
   Patch attached.
   
   Jan
   

2. Re: compile error with -DOPTIMIZER_DEBUG

   Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> — 2009-11-22T14:55:30Z

   Jan Urbański wrote:
   > ISTM that there's a superfluous curly brace in print_path (which only
   > gets compiled with -DOPTIMIZER_DEBUG.
   > 
   > Patch attached.
   
   Thanks, committed.
   
   -- 
     Heikki Linnakangas
     EnterpriseDB   http://www.enterprisedb.com
   
   

3. Re: compile error with -DOPTIMIZER_DEBUG

   Tom Lane <tgl@sss.pgh.pa.us> — 2009-11-22T16:41:19Z

   Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
   > Jan Urbaski wrote:
   >> ISTM that there's a superfluous curly brace in print_path (which only
   >> gets compiled with -DOPTIMIZER_DEBUG.
   
   > Thanks, committed.
   
   You know, the last couple of times I've touched that code, I've been
   wondering why we bother to maintain it.  Personally I always use pprint()
   when I'm interested in a printout of a plan tree.  Is anyone actually
   using the printout code in allpaths.c?
   
   			regards, tom lane
   
   

4. Re: compile error with -DOPTIMIZER_DEBUG

   Bruce Momjian <bruce@momjian.us> — 2009-11-29T11:33:49Z

   Tom Lane wrote:
   > Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
   > > Jan Urbaski wrote:
   > >> ISTM that there's a superfluous curly brace in print_path (which only
   > >> gets compiled with -DOPTIMIZER_DEBUG.
   > 
   > > Thanks, committed.
   > 
   > You know, the last couple of times I've touched that code, I've been
   > wondering why we bother to maintain it.  Personally I always use pprint()
   > when I'm interested in a printout of a plan tree.  Is anyone actually
   > using the printout code in allpaths.c?
   
   I thought OPTIMIZER_DEBUG showed us all the possible paths, not just the
   final plan.
   
   -- 
     Bruce Momjian  <bruce@momjian.us>        http://momjian.us
     EnterpriseDB                             http://enterprisedb.com
   
     + If your life is a hard drive, Christ can be your backup. +
   
   

5. Re: compile error with -DOPTIMIZER_DEBUG

   Tom Lane <tgl@sss.pgh.pa.us> — 2009-11-29T14:35:34Z

   Bruce Momjian <bruce@momjian.us> writes:
   > Tom Lane wrote:
   >> You know, the last couple of times I've touched that code, I've been
   >> wondering why we bother to maintain it.  Personally I always use pprint()
   >> when I'm interested in a printout of a plan tree.  Is anyone actually
   >> using the printout code in allpaths.c?
   
   > I thought OPTIMIZER_DEBUG showed us all the possible paths, not just the
   > final plan.
   
   Yeah, but we could repoint that code at pprint.
   
   			regards, tom lane
   
   

6. Re: compile error with -DOPTIMIZER_DEBUG

   Alvaro Herrera <alvherre@commandprompt.com> — 2009-12-02T15:02:17Z

   Tom Lane wrote:
   > Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
   > > Jan Urbański wrote:
   > >> ISTM that there's a superfluous curly brace in print_path (which only
   > >> gets compiled with -DOPTIMIZER_DEBUG.
   > 
   > > Thanks, committed.
   > 
   > You know, the last couple of times I've touched that code, I've been
   > wondering why we bother to maintain it.  Personally I always use pprint()
   > when I'm interested in a printout of a plan tree.  Is anyone actually
   > using the printout code in allpaths.c?
   
   Maybe Tom Raney's Visual Planner thing?
   
   -- 
   Alvaro Herrera                                http://www.CommandPrompt.com/
   PostgreSQL Replication, Consulting, Custom Development, 24x7 support